Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve references in RUSTSEC-2024-0359 #2202

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Improve references in RUSTSEC-2024-0359 #2202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d4a371
Improve attribution in RUSTSEC-2024-0359
EliahKagan Jan 18, 2025
3a710b1
Update RUSTSEC-2024-0359 external info metadata
EliahKagan Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/gix-attributes/RUSTSEC-2024-0359.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
id = "RUSTSEC-2024-0359"
package = "gix-attributes"
date = "2024-07-24"
url = "https://github.com/Byron/gitoxide/issues/1460"
url = "https://github.com/GitoxideLabs/gitoxide/issues/1460"
informational = "unsound"
aliases = ["GHSA-cx7h-h87r-jpgr"]

[versions]
patched = [">= 0.22.3"]
Expand All @@ -21,3 +22,5 @@ patched = [">= 0.22.3"]
The problem is that the non-UTF8 `str` **is** exposed to outside code: first to the `kstring` crate itself, which requires UTF-8 in its documentation and may have UB as a consequence of this, but also to `serde`, where it propagates to e.g. `serde_json`, `serde_yaml`, etc., where the same problems occur.

This is not sound, and it could cause further UB down the line in these places that can view the `&str`.

*Thanks to [Devin Jeanpierre](https://github.com/ssbr) for discovering and reporting this issue.*
Loading