Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advisories for unmaintained gtk-rs GTK3 bindings #2164

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

sdroege
Copy link
Contributor

@sdroege sdroege commented Dec 9, 2024

No description provided.

@Shnatsel
Copy link
Member

Shnatsel commented Dec 9, 2024

Thank you for the PR!

CI fails because there is no gdk-x11-sys package on crates.io.

@sdroege sdroege force-pushed the gtk-rs-3-unmaintained branch from 22ffa42 to e6e2b82 Compare December 9, 2024 12:01
@sdroege
Copy link
Contributor Author

sdroege commented Dec 9, 2024

CI fails because there is no gdk-x11-sys package on crates.io.

Thanks, there was a - too much :)

@Shnatsel
Copy link
Member

Shnatsel commented Dec 9, 2024

Could you add a note that this is coming from the actual maintainers, to make the source of the notice more clear? Mentioning that the repositories have been archived might also be helpful. Thank you!

@sdroege sdroege force-pushed the gtk-rs-3-unmaintained branch from e6e2b82 to 856c49a Compare December 9, 2024 12:17
@sdroege
Copy link
Contributor Author

sdroege commented Dec 9, 2024

Done, good idea

@Shnatsel
Copy link
Member

Shnatsel commented Dec 9, 2024

Thanks! Looks good, merging.

@Shnatsel Shnatsel merged commit d6aa1d0 into rustsec:main Dec 9, 2024
1 check passed
@sdroege sdroege deleted the gtk-rs-3-unmaintained branch December 9, 2024 12:33
github-merge-queue bot pushed a commit to firezone/firezone that referenced this pull request Dec 11, 2024
Tauri still depends on GTK3 which is now officially unmaintained
(rustsec/advisory-db#2164). I've asked the Tauri
team for a position on it
(tauri-apps/tauri#11942). In the meantime,
we'll have to allow the use of these unmaintained crates to unblock CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants