-
Notifications
You must be signed in to change notification settings - Fork 377
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RUSTSEC-2024-0344: fix links (#1983)
Adds angle brackets to all links so they render properly on rustsec.org
- Loading branch information
Showing
1 changed file
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,23 +20,23 @@ The `Scalar29::sub` (32-bit) and `Scalar52::sub` (64-bit) functions contained us | |
inside a loop where LLVM saw an opportunity to insert a branch instruction (`jns` on x86) to | ||
conditionally bypass this code section when the mask value is set to zero as can be seen in godbolt: | ||
|
||
- 32-bit (see L106): https://godbolt.org/z/zvaWxzvqv | ||
- 64-bit (see L48): https://godbolt.org/z/PczYj7Pda | ||
- 32-bit (see L106): <https://godbolt.org/z/zvaWxzvqv> | ||
- 64-bit (see L48): <https://godbolt.org/z/PczYj7Pda> | ||
|
||
A similar problem was recently discovered in the Kyber reference implementation: | ||
|
||
https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/hqbtIGFKIpU/m/cnE3pbueBgAJ | ||
<https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/hqbtIGFKIpU/m/cnE3pbueBgAJ> | ||
|
||
As discussed on that thread, one portable solution, which is also used in this PR, is to introduce a | ||
volatile read as an optimization barrier, which prevents the compiler from optimizing it away. | ||
|
||
The fix can be validated in godbolt here: | ||
|
||
- 32-bit: https://godbolt.org/z/jc9j7eb8E | ||
- 64-bit: https://godbolt.org/z/x8d46Yfah | ||
- 32-bit: <https://godbolt.org/z/jc9j7eb8E> | ||
- 64-bit: <https://godbolt.org/z/x8d46Yfah> | ||
|
||
The problem was discovered and the solution independently verified by | ||
Alexander Wagner <[email protected]> and Lea Themint <[email protected]> using | ||
their DATA tool: | ||
|
||
https://github.com/Fraunhofer-AISEC/DATA | ||
<https://github.com/Fraunhofer-AISEC/DATA> |