fix: OpenFile::read_at no longer errors on invalid offset or length #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
simonsan
reviewed
Oct 14, 2024
simonsan
approved these changes
Oct 14, 2024
simonsan
added
C-bug
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
## 🤖 New release * `rustic_backend`: 0.4.1 -> 0.4.2 (✓ API compatible changes) * `rustic_core`: 0.5.3 -> 0.5.4 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `rustic_backend` <blockquote> ## [0.4.2](rustic_backend-v0.4.1...rustic_backend-v0.4.2) - 2024-10-24 ### Fixed - fix opendal paths on windows ([#340](#340)) </blockquote> ## `rustic_core` <blockquote> ## [0.5.4](rustic_core-v0.5.3...rustic_core-v0.5.4) - 2024-10-24 ### Added - *(commands)* Add convenient names for read-data-subset n/m ([#328](#328)) ### Fixed - OpenFile::read_at no longer errors on invalid offset or length ([#331](#331)) ### Other - *(deps)* update actions ([#338](#338)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to rustic-rs/rustic
that referenced
this pull request
Nov 10, 2024
This PR adds the `mount` command to rustic to access snapshot contents
as a read-only filesystem when the feature-flag `mount` is chosen.
As for the `webdav` command, there are following options:
- Access to a concrete snapshot/path, e.g. `rustic mount /mnt
37a63e5b:/my/path`.
- Access to all snapshots (maybe restricted by filters) by using
templates to define a virtual directory structure where snapshots are
located. Example: `rustic mount /mnt --path-template
"[{hostname}]/[{label}]/{time}" --time-template "%Y-%m-%d_%H-%M-%S"`
(these are also defined as default). Note that for all dirs containing
only snapshots, also a `latest` entry is generated. `latest` and
identical subsequent snapshots are symlinks when using `mount`.
This PR uses fuse_mt which is not optimal as it introduces some overhead
(e.g. needs to save whole Paths in-memory).
Note: Requires rustic-rs/rustic_core#331 to
properly show all data of files (without it builds and runs, but files
are truncated and return error when reading).
Note: Building with the `mount` feature flag requires special
dependencies and is only possible on supported platforms, see
https://github.com/cberner/fuser
closes #971
---------
Co-authored-by: simonsan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed if weired access to the
OpenFileis made. This is e.g. the case for themountcommand.Also the docu of the affected methods has been clarified.