-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octernship assignment submission #15
Conversation
what??? i thought we were supposed to do the pr in the specific repository github classroom created and not this template one... |
yeah me too, but then there's like a bunch of people doing it here anyways there's no central discussion so everyone is confused really i'm just doing both |
Decided to make a recording of the app in action to make it easier to evaluate. As said in the README, it checks which methods are feasible on the system it's ran, and then provides the option to switch between them. In my WSL environment, You can see this demonstrated here: Using WSLrustdesk-wsl-trim.mp4Using VMrustdesk-vm-trim.mp4 |
@devporter007 looks like we finally got confirmation |
Thanks for informing me bud, rustdesk should have made this clear early on... |
Looks good. |
you will review the pr submitted in private repos too right? |
BTW, how can we mark someone to "Passing" status in the classroom page? I can not see any link or button to make this change. Also, is there any good way to remove these robot generated repos (>500 repos, no way to delete manually one by one) without api? |
@rustdesk looking at the Octernship Handbook under Reviewing Student Submissions, it appears you need to click the "Repository" button beside each submission to evaluate it. Perhaps there you can then mark it as "Passing". I assume the button will take you to the private generated repo, and there'll be buttons to communicate with the student or change the status of the submission. Unfortunately, the demo video is broken, so I'm not exactly sure how it would look like to you - I'll make sure they're notified by opening an issue. Then you'll have to notify GitHub staff of your selections using the And I see no way of removing submissions on a mass scale - becuase determining whether one is "robot-generated" might lead to inadvertently removing some human submissions. I think the best bet is to just look at the commit contents, and if it's not satisfactory, fail the submission. Maybe you should contact them at [email protected] for more help? |
The demo video might only be broken for me...I use a beta version of both Firefox and Windows, but I've opened an issue |
not really sure if the public repos count towards anything at this point, so i apologise if i’m making a fuss, but #20 and #21 appear to have copied my repo contents and are attempting to pass them off as their own:
|
Hey @rustdesk, I have submitted my assignment in the private repo. Are you going to review the private repos too? |
@rustdesk |
it's been a while and i think they didn't actually accept anyone, so closing |
Since this one is not as good as https://github.com/rustdesk-org/authenticate-without-polkit-sahilyeole/pull/5#discussion_r1275940856 |
@rustdesk oh that's cool, but that's a private repository, any chance we could get access to the code so we could improve? |
No need to spend more time on this. But if you are really interested, you can try a real project. |
yes write i give some time tough but ..... it is an interesting project ... |
I'm not quite sure whether how exactly to submit this assignment, I've made a branch in the GitHub Classroom generated one and opened a PR there but since a few people are making PRs against this I figured I might as well do that too.
I had to rebase all my commits against rustdesk-org/Octernships_Project, but all my changes were made before the deadline (the timestamps in the private repo can be used to verify this)