Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octernship assignment submission #15

Closed
wants to merge 13 commits into from

Conversation

poopsicles
Copy link

@poopsicles poopsicles commented Jun 20, 2023

I'm not quite sure whether how exactly to submit this assignment, I've made a branch in the GitHub Classroom generated one and opened a PR there but since a few people are making PRs against this I figured I might as well do that too.

I had to rebase all my commits against rustdesk-org/Octernships_Project, but all my changes were made before the deadline (the timestamps in the private repo can be used to verify this)

@devporter007
Copy link

what??? i thought we were supposed to do the pr in the specific repository github classroom created and not this template one...

@poopsicles
Copy link
Author

what??? i thought we were supposed to do the pr in the specific repository github classroom created and not this template one...

yeah me too, but then there's like a bunch of people doing it here anyways

there's no central discussion so everyone is confused really

i'm just doing both

@poopsicles
Copy link
Author

I'm making a copy of my comment in the private repo over here in case this is the canonical submission way

Decided to make a recording of the app in action to make it easier to evaluate.

As said in the README, it checks which methods are feasible on the system it's ran, and then provides the option to switch between them.

In my WSL environment, polkit isn't installed (due to the lack of a desktop environment) so it doesn't offer the option. Instead sudo and su are available as a fallback. Contrary to that, my Fedora VirtualBox VM does have polkit so it tries to use that first, only falling back to the other options when that one fails.

You can see this demonstrated here:

Using WSL

rustdesk-wsl-trim.mp4

Using VM

rustdesk-vm-trim.mp4

@poopsicles
Copy link
Author

@devporter007 looks like we finally got confirmation

@devporter007
Copy link

devporter007 commented Jun 21, 2023

@devporter007 looks like we finally got confirmation

Thanks for informing me bud, rustdesk should have made this clear early on...

@rustdesk
Copy link

rustdesk commented Jun 29, 2023

Looks good.

@devporter007
Copy link

Looks good.

you will review the pr submitted in private repos too right?

@rustdesk
Copy link

PR there

https://github.com/rustdesk-org/authenticate-without-polkit-poopsicles/pull/1#issuecomment-1612777717

BTW, how can we mark someone to "Passing" status in the classroom page? I can not see any link or button to make this change. Also, is there any good way to remove these robot generated repos (>500 repos, no way to delete manually one by one) without api?

image

@poopsicles
Copy link
Author

@rustdesk looking at the Octernship Handbook under Reviewing Student Submissions, it appears you need to click the "Repository" button beside each submission to evaluate it. Perhaps there you can then mark it as "Passing".

I assume the button will take you to the private generated repo, and there'll be buttons to communicate with the student or change the status of the submission.

Unfortunately, the demo video is broken, so I'm not exactly sure how it would look like to you - I'll make sure they're notified by opening an issue.

Then you'll have to notify GitHub staff of your selections using the Octern Selection Form as detailed in the Selecting candidates for your Octernship heading.

And I see no way of removing submissions on a mass scale - becuase determining whether one is "robot-generated" might lead to inadvertently removing some human submissions. I think the best bet is to just look at the commit contents, and if it's not satisfactory, fail the submission.

Maybe you should contact them at [email protected] for more help?

@poopsicles
Copy link
Author

The demo video might only be broken for me...I use a beta version of both Firefox and Windows, but I've opened an issue

github-education-resources/Octernships#18

@poopsicles
Copy link
Author

not really sure if the public repos count towards anything at this point, so i apologise if i’m making a fuss, but #20 and #21 appear to have copied my repo contents and are attempting to pass them off as their own:

This was referenced Jul 1, 2023
@beelchester
Copy link

beelchester commented Jul 1, 2023

Hey @rustdesk, I have submitted my assignment in the private repo. Are you going to review the private repos too?
Btw, amazing work @poopsicles It's really impressive.

@anupam577
Copy link

@rustdesk
How many more days will it take for the submission to be reviewed?

@poopsicles
Copy link
Author

it's been a while and i think they didn't actually accept anyone, so closing

@poopsicles poopsicles closed this Aug 29, 2023
@poopsicles poopsicles deleted the add-main-assignment branch August 29, 2023 17:35
@rustdesk
Copy link

@poopsicles
Copy link
Author

@rustdesk oh that's cool, but that's a private repository, any chance we could get access to the code so we could improve?

@rustdesk
Copy link

No need to spend more time on this. But if you are really interested, you can try a real project.

@brambhattabhishek
Copy link

yes write i give some time tough but ..... it is an interesting project ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants