wayland: ignore events for dead objects #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
requested changes
Jul 3, 2024
| return; | ||
| } | ||
| seat_state | ||
| }, | ||
| None => return, |
There was a problem hiding this comment.
Should we also warn on this branch?
There was a problem hiding this comment.
I've made it a bit more broken compositor proof, though, keep in mind that the old code is like that for like ~7 years, it's just some 4chan devs decided to yolo recently.
Comment on lines
47
to
50
| if seat_state.pointer.is_none() { | ||
| warn!("Received pointer event without pointer"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Instead of doing is_none, we should use a match here and out the result into a let pointer variable. That way we don't have to unwrap below.
There was a problem hiding this comment.
I refactored that way because I've assumed that it'll fail due to borrowing somehow, however it seems to work.
Nothing wrong will happen if we ignore events when compositor is at wrong, at least crashing because compositor is just _wrong_ probably is not a great option. Links: alacritty/alacritty#8065
kchibisov
force-pushed
the
kchibisov/wayland-ignore-broken
branch
from
e7397d6 to
ad4a4e5
Compare
notgull
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing wrong will happen if we ignore events when compositor is at wrong, at least crashing because compositor is just wrong probably is not a great option.
Links: alacritty/alacritty#8065
changelogmodule if knowledge of this change could be valuable to users--
Whatever, the other part of this "fix" will require Smithay/client-toolkit#461 , though, it could be patch bumped by the library users.