Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm-bindgen feature to enable argmin/wasm-bindgen #329

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

atsuik
Copy link
Contributor

@atsuik atsuik commented Jan 11, 2024

To complie linfa with wasm-bindgen and use it from Browser, I add a new feature flag wasm-bindgen to Cargo.tom for

  • linfa-ftrl
  • linfa-linear
  • linfa-logistic
    , which crates depend on argmin crate.

The new feature looks like this.

[features]
wasm-bindgen = ["argmin/wasm-bindgen"]

argmin has feature flag wasm-bindgen to use this crate with wasm-bindgen.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ade794) 36.21% compared to head (b659ed0) 36.15%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   36.21%   36.15%   -0.07%     
==========================================
  Files          92       92              
  Lines        6218     6218              
==========================================
- Hits         2252     2248       -4     
- Misses       3966     3970       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@quietlychris quietlychris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool to see this potentially getting used in a WASM environment!

@quietlychris quietlychris merged commit 9220765 into rust-ml:master Jan 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants