Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TLSv1.3 with curl if specified at all #2996

Closed
wants to merge 1 commit into from

Conversation

pothos
Copy link

@pothos pothos commented May 26, 2022

The curl option specified to use TLSv1.2 explicity while nowadays 1.3
is availalble and recommended.
Switch to specifying 1.3 instead of 1.2 for the command that downloads
the install script. The rustup-init.sh script itself it left with the
ciphersuite selection plus 1.2 and fallbacks as is.

See rust-lang/book#3130

@pothos
Copy link
Author

pothos commented May 26, 2022

Related, can someone point me at the repo for the website source code? The 1.2 option is used there, too: https://rustup.rs/

Edit: Found more places: https://github.com/search?q=org:rust-lang+rustup+tlsv1.2&type=code

The curl option specified to use TLSv1.2 explicity while nowadays 1.3
is availalble and recommended.
Switch to specifying 1.3 instead of 1.2 for the command that downloads
the install script. The rustup-init.sh script itself it left with the
ciphersuite selection plus 1.2 and fallbacks as is.
@pothos
Copy link
Author

pothos commented May 27, 2022

I didn't touch the logic for ciphersuite selection with 1.2 and the fallbacks. Should we create an issue for that? Edit: No, it already exists: #2581

@rbtcollins
Copy link
Contributor

What are the compatibility implications of this? My understanding is that the reason we specify the tls parameter is defence-in-depth to prevent down grade attacks, but we do presumably want some somewhat older OSes to be able to install still?

@pothos
Copy link
Author

pothos commented Aug 15, 2022

This got discussed in rust-lang/www.rust-lang.org#1670 - I'm fine with closing this if it shouldn't stay open for the future.

@kinnison kinnison closed this Aug 27, 2022
@kinnison
Copy link
Contributor

Closed - we can revisit if/when tls1.3 is sufficiently widespread that we're not risking hurting people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants