Implement remove_nested_blocks option #6489
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements new feature that removes nested blocks #5616.
The feature is similar to
remove_nested_parens
. Blocks with any sort of comments or attributes,unsafe
andconst
blocks will not be removed. This however will not remove all nested blocks, instead it will leave the innermost block (similar toremove_nested_parens
). That behavior differs from suggested in the issue, and I'm not sure which one is better.I'm not fully satisfied with my implementation, so any suggestions are appreciated.
I also was not sure what do do if nested blocks are of different kind (nested
const
and/orunsafe
blocks), so I decided to only remove 'naked' blocks, and just never removeconst
andunsafe
blocks. There is some merit to removingunsafe
orconst
blocks when only blocks of one kind are nested, but for the sake of consistency I decided to not do that. An example of such problematic situation:As I said, for now both
mixed
, andone_kind
functions would only remove the blocks annotated by comments.I'm open for suggestions regarding the behavior, since the feature in the original issue was very loosely defined (also blocks are more tricky than parentheses)