Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labels on the closure body block can be disappearing #6468

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

anatawa12
Copy link
Contributor

Fixes #6465

This PR also adds many test cases for labels on the closure body block.

@anatawa12
Copy link
Contributor Author

@rustbot ready

@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2025

Error: The feature shortcut is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the feedback. I've got one last ask before we merge this.

Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting this issue and helping to fix it.

@ytmimi
Copy link
Contributor

ytmimi commented Feb 12, 2025

Running one last CI check

Edit: Job passed ✅

@ytmimi ytmimi merged commit 5619b64 into rust-lang:master Feb 12, 2025
26 checks passed
@ytmimi ytmimi added release-notes Needs an associated changelog entry and removed pr-ready-to-merge labels Feb 12, 2025
@anatawa12
Copy link
Contributor Author

Today I found that there is copy of rustfmt in rust-lang/rust tree. is it better to send pull request to rust-lang/rust tree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes Needs an associated changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustfmt removes labels of block if inside macro invocation, which will break the code
3 participants