Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use semver to match required version #6066

Merged
merged 48 commits into from
Feb 26, 2025
Merged

feat: use semver to match required version #6066

merged 48 commits into from
Feb 26, 2025

Conversation

ologbonowiwi
Copy link
Contributor

  • test: add test for required_version
  • chore: install semver
  • refactor: use semver to compare versions
  • fix: use exact version for comparison when no comparator is specified
  • refactor: avoid overhead by considering default behavior from semver
  • test: add complex comparisons for required_version
  • refactor: handle required_version parsing manually

Closes #6063

@ologbonowiwi ologbonowiwi mentioned this pull request Feb 9, 2024
Closed
ytmimi
ytmimi reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this one so soon. I'll be a little busy this coming weekend so I wanted to at least get my initial review done now. Good stuff so far!

@ologbonowiwi
Copy link
Contributor Author

changes addressed @ytmimi. Thanks for the quick feedback 😄

ytmimi
ytmimi reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more notes, but we're moving in the right direction

ytmimi
ytmimi reviewed Oct 10, 2024
View reviewed changes
@ologbonowiwi ologbonowiwi requested a review from ytmimi October 10, 2024 17:55
ytmimi
ytmimi reviewed Oct 10, 2024
View reviewed changes
ytmimi
ytmimi reviewed Oct 10, 2024
View reviewed changes
@ologbonowiwi ologbonowiwi force-pushed the feat/#6063/use-semver-to-check-required-version branch from ea85318 to 4e15dbf Compare October 10, 2024 18:07
@ologbonowiwi ologbonowiwi requested a review from ytmimi October 10, 2024 18:07
ytmimi
ytmimi reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor note about rewording the #### Multiple version to match docs and maybe adding another test case for the wildcard match.

@ologbonowiwi ologbonowiwi requested a review from ytmimi February 18, 2025 21:39
@ologbonowiwi
Copy link
Contributor Author

appreciate the feedback and patience @ytmimi, great rewording on those docs.

lmk if there's anything else 🎉

ytmimi
ytmimi approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just re-reviewed the changes. Thanks again for sticking with this 🎉

@ytmimi ytmimi merged commit 328f453 into rust-lang:master Feb 26, 2025
26 checks passed
@ytmimi ytmimi added release-notes Needs an associated changelog entry and removed pr-follow-up-review-pending labels Feb 26, 2025
@ologbonowiwi ologbonowiwi deleted the feat/#6063/use-semver-to-check-required-version branch February 26, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi approved these changes

Assignees
No one assigned
Labels
release-notes Needs an associated changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use semver to check required_version instead of comparing two strings with !=
3 participants
@ologbonowiwi @ytmimi @rustbot