-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error handling when looking for toolchain components #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
approved these changes
Dec 15, 2024
Kobzol
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2025
bump `rustc-perf` submodule This updates the `rustc-perf` submodule to pull in the recent changes, in particular the error handling in rust-lang/rustc-perf#2021 fixing the error we saw in a recent run. I think I did this correctly, submodules are so annoying. r? kobzol (opening as draft to do a perf run and check that nothing has changed indeed)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 11, 2025
bump `rustc-perf` submodule This updates the `rustc-perf` submodule to pull in the recent changes, in particular the error handling in rust-lang/rustc-perf#2021 fixing the error we saw in a recent run. I think I did this correctly, submodules are so annoying. r? kobzol (opening as draft to do a perf run and check that nothing has changed indeed)
github-merge-queue bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Jan 20, 2025
bump `rustc-perf` submodule This updates the `rustc-perf` submodule to pull in the recent changes, in particular the error handling in rust-lang/rustc-perf#2021 fixing the error we saw in a recent run. I think I did this correctly, submodules are so annoying. r? kobzol (opening as draft to do a perf run and check that nothing has changed indeed)
Kobzol
pushed a commit
to Kobzol/rustc-dev-guide
that referenced
this pull request
Jan 20, 2025
bump `rustc-perf` submodule This updates the `rustc-perf` submodule to pull in the recent changes, in particular the error handling in rust-lang/rustc-perf#2021 fixing the error we saw in a recent run. I think I did this correctly, submodules are so annoying. r? kobzol (opening as draft to do a perf run and check that nothing has changed indeed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The perf collector failed weirdly in rust-lang/rust#134297 (comment). It failed when the collector was trying to gather PGO data, with a very terse error:
collector error: Cannot read lib dir to find components
.So this PR:
fill_libraries
get_lib_dir_from_rustc
which didn't check thatrustc --print sysroot
successfully returned the sysroot, it'll print the exit status and stderr.With these we can see that the error was a cute one, the stage2 rustc panicked when asked to print the sysroot. So the error in the CI logs would now look like:
Once this lands, I'll bump the submodule in the rust repo so that CI has the new error handling, in case it happens again in the PRs trying to land the same changes that may currently cause a miscompile 😓.