Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a unique directory for self-profile output #1797

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Use a unique directory for self-profile output #1797

merged 1 commit into from
Jan 8, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jan 8, 2024

It is not straightforward to thread all the distinguishing benchmark parameters to rustc-fake, so something like this should hopefully be future-proof and unique enough.

@Kobzol
Use a unique directory for self-profile output
32f1c5c 
It is not straightforward to thread all the distinguishing benchmark parameters to `rustc-fake`, so something like this should hopefully be future-proof and unique enough.
@Kobzol Kobzol requested a review from Mark-Simulacrum January 8, 2024 20:05
@Kobzol Kobzol enabled auto-merge January 8, 2024 23:01
@Kobzol Kobzol merged commit 66faa28 into rust-lang:master Jan 8, 2024
11 checks passed
@Kobzol Kobzol deleted the self-profile-unique-dir branch January 8, 2024 23:02
Kobzol added a commit to Kobzol/rustc-perf that referenced this pull request Jan 9, 2024
@Kobzol
Revert "Merge pull request rust-lang#1797 from Kobzol/self-profile-un…
19a76cf 
…ique-dir"

This reverts commit 66faa28, reversing
changes made to cd37384.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @Mark-Simulacrum