database: move bins to separate crates #1783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I wonder what's the motivation for this? Just reducing compile times for the collector/site binaries? |
|
Yes, size too; plus more clear separation of functionality/dependencies. |
|
It seems to remove only two dependencies from collector/site, and doesn't affect their binary sizes a lot (1 KiB for collector it seems), so I'm not sure if it's worth the churn. That being said, it probably doesn't hurt. Let's see what Mark thinks. |
|
No immediate effect, yes. |
|
My sense is that this isn't worth the additional complexity. |
|
Okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There no way to do bin only dependencies today, so move bins from database; eventually allows to build less unneeded crates via dependencies.
Played around with crate features; hope there no surprise with cargo feature merge.