Add compile benchmark detail endpoint #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
benchmark-detail-api
branch
from
008f9b0 to
8dc0423
Compare
This was referenced Nov 16, 2023
Mark-Simulacrum
approved these changes
Nov 24, 2023
It was created a few years ago, but it wasn't actually used anywhere.
Kobzol
force-pushed
the
benchmark-detail-api
branch
from
8dc0423 to
b4b44f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new endpoint for returning the data of a compile benchmark detail (the thing that is shown when you click on a specific row on the compile benchmark compare page). Before, two separate API calls had to be made.
I want to add more data to this detail endpoint in the future, so I created a new endpoint to put everything into a single place.