Add basic support for selecting a codegen backend for compile benchmarks #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
reviewed
Nov 9, 2023
nnethercote
reviewed
Nov 9, 2023
nnethercote
reviewed
Nov 9, 2023
nnethercote
reviewed
Nov 9, 2023
nnethercote
approved these changes
Nov 9, 2023
Kobzol
force-pushed
the
codegen-backend
branch
from
782fb63 to
adb397d
Compare
|
Thanks for taking a look, I have resolved the comments. |
Kobzol
force-pushed
the
codegen-backend
branch
from
adb397d to
53f5129
Compare
|
Turns our that |
Kobzol
force-pushed
the
codegen-backend
branch
from
53f5129 to
60420cd
Compare
|
Rebased to fix conflict. |
Also removes the `possible_values` implementation. It wasn't used by Clap anyway.
Mark-Simulacrum
approved these changes
Nov 24, 2023
Since we're already modifying the pstat_series table, this commit also renames the cache column to scenario, and the statistic column to metric, to resolve a long-standing mismatch in the terminology.
Kobzol
force-pushed
the
codegen-backend
branch
from
60420cd to
83140fb
Compare
|
Here goes nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new parameter for compilation benchmarks - a codegen backend. It adds support for it to the collector and the database. It does not yet modify the web UI, and it also doesn't add other backends than the default one (LLVM).
The database changes will require the most review scrutiny. I tested the DB migration for both SQLite and Postgre locally.
Best reviewed commit by commit.