-
Notifications
You must be signed in to change notification settings - Fork 152
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2029 from Kobzol/triage-2025-01-07
Triage 2025 01 07
- Loading branch information
Showing
1 changed file
with
99 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| # 2025-01-07 Triage Log | ||
|
|
||
| A quiet week with not much going on. A small regression was caused by a bugfix related to traits, but | ||
| it was somewhat offset by a cargo update that brought a small perf. win. | ||
|
|
||
| Triage done by **@kobzol**. | ||
| Revision range: [93722f7e..0f1e965f](https://perf.rust-lang.org/?start=93722f7ed56bcf27839a6355074095c4320b7d37&end=0f1e965fec3bc2f97b932e9dd8e85fca6d7faadc&absolute=false&stat=instructions%3Au) | ||
|
|
||
| **Summary**: | ||
|
|
||
| | (instructions:u) | mean | range | count | | ||
| |:----------------------------------:|:-----:|:--------------:|:-----:| | ||
| | Regressions ❌ <br /> (primary) | 0.4% | [0.1%, 1.1%] | 20 | | ||
| | Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 2.5%] | 19 | | ||
| | Improvements ✅ <br /> (primary) | -0.4% | [-1.6%, -0.2%] | 8 | | ||
| | Improvements ✅ <br /> (secondary) | -1.3% | [-1.7%, -0.2%] | 13 | | ||
| | All ❌✅ (primary) | 0.1% | [-1.6%, 1.1%] | 28 | | ||
|
|
||
|
|
||
| 0 Regressions, 2 Improvements, 4 Mixed; 4 of them in rollups | ||
| 51 artifact comparisons made in total | ||
|
|
||
| #### Improvements | ||
|
|
||
| Rollup of 4 pull requests [#135059](https://github.com/rust-lang/rust/pull/135059) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ac00fe89a121e9ca5e59c093c7c02aa296e55ece&end=319f5292a19951d13f3c79c04b3cf3d1501d9e79&stat=instructions:u) | ||
|
|
||
| | (instructions:u) | mean | range | count | | ||
| |:----------------------------------:|:-----:|:--------------:|:-----:| | ||
| | Regressions ❌ <br /> (primary) | - | - | 0 | | ||
| | Regressions ❌ <br /> (secondary) | - | - | 0 | | ||
| | Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.1%] | 5 | | ||
| | Improvements ✅ <br /> (secondary) | - | - | 0 | | ||
| | All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 | | ||
|
|
||
|
|
||
| Rollup of 7 pull requests [#135086](https://github.com/rust-lang/rust/pull/135086) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3f43b1a636738f41c48df073c5bcb97a97bf8459&end=8d2c06d151972fefa3f0bbf04ace3beede737145&stat=instructions:u) | ||
|
|
||
| | (instructions:u) | mean | range | count | | ||
| |:----------------------------------:|:-----:|:--------------:|:-----:| | ||
| | Regressions ❌ <br /> (primary) | - | - | 0 | | ||
| | Regressions ❌ <br /> (secondary) | - | - | 0 | | ||
| | Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 7 | | ||
| | Improvements ✅ <br /> (secondary) | - | - | 0 | | ||
| | All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 7 | | ||
|
|
||
|
|
||
| #### Mixed | ||
|
|
||
| Update cargo [#135089](https://github.com/rust-lang/rust/pull/135089) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8d2c06d151972fefa3f0bbf04ace3beede737145&end=d13c80a6fdd915ec35d7882122e5f221e8f27a18&stat=instructions:u) | ||
|
|
||
| | (instructions:u) | mean | range | count | | ||
| |:----------------------------------:|:-----:|:--------------:|:-----:| | ||
| | Regressions ❌ <br /> (primary) | - | - | 0 | | ||
| | Regressions ❌ <br /> (secondary) | 0.9% | [0.9%, 0.9%] | 1 | | ||
| | Improvements ✅ <br /> (primary) | -0.1% | [-0.2%, -0.1%] | 38 | | ||
| | Improvements ✅ <br /> (secondary) | -0.3% | [-0.6%, -0.1%] | 35 | | ||
| | All ❌✅ (primary) | -0.1% | [-0.2%, -0.1%] | 38 | | ||
|
|
||
| - Many small improvements and only a tiny regression. | ||
| - Marked as triaged. | ||
|
|
||
| Project to `TyKind::Error` when there are unconstrained non-lifetime (ty/const) impl params [#135057](https://github.com/rust-lang/rust/pull/135057) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d13c80a6fdd915ec35d7882122e5f221e8f27a18&end=7349f6b50359fd1f11738765b8deec5ee02d8710&stat=instructions:u) | ||
|
|
||
| | (instructions:u) | mean | range | count | | ||
| |:----------------------------------:|:-----:|:--------------:|:-----:| | ||
| | Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.3%] | 76 | | ||
| | Regressions ❌ <br /> (secondary) | 0.3% | [0.0%, 0.7%] | 39 | | ||
| | Improvements ✅ <br /> (primary) | - | - | 0 | | ||
| | Improvements ✅ <br /> (secondary) | -1.0% | [-1.0%, -1.0%] | 1 | | ||
| | All ❌✅ (primary) | 0.2% | [0.1%, 0.3%] | 76 | | ||
|
|
||
| - Small performance loss, but this was a bugfix, so it was deemed justifiable. | ||
| - Marked as triaged. | ||
|
|
||
| Rollup of 6 pull requests [#135101](https://github.com/rust-lang/rust/pull/135101) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ead4a8f53624f3b4a9ee833421fbf8a48bc07aca&end=1891c28669863bf7ed3ef8f43f2d3fa546f34861&stat=instructions:u) | ||
|
|
||
| | (instructions:u) | mean | range | count | | ||
| |:----------------------------------:|:-----:|:--------------:|:-----:| | ||
| | Regressions ❌ <br /> (primary) | 0.7% | [0.7%, 0.8%] | 4 | | ||
| | Regressions ❌ <br /> (secondary) | 0.7% | [0.3%, 2.2%] | 4 | | ||
| | Improvements ✅ <br /> (primary) | - | - | 0 | | ||
| | Improvements ✅ <br /> (secondary) | -1.3% | [-1.8%, -0.2%] | 13 | | ||
| | All ❌✅ (primary) | 0.7% | [0.7%, 0.8%] | 4 | | ||
|
|
||
| - The `deep-vector` benchmark changes were most likely caused by [#135046](https://github.com/rust-lang/rust/pull/135046). | ||
| - Marked as triaged. | ||
|
|
||
| Rollup of 3 pull requests [#135140](https://github.com/rust-lang/rust/pull/135140) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=feb32c654619e50eda8408f9241d4cb7b948fea5&end=56f9e6f935f9b0d6e83092a0f86d4dbeb878f17d&stat=instructions:u) | ||
|
|
||
| | (instructions:u) | mean | range | count | | ||
| |:----------------------------------:|:-----:|:--------------:|:-----:| | ||
| | Regressions ❌ <br /> (primary) | 0.5% | [0.5%, 0.6%] | 2 | | ||
| | Regressions ❌ <br /> (secondary) | - | - | 0 | | ||
| | Improvements ✅ <br /> (primary) | -1.7% | [-1.7%, -1.7%] | 1 | | ||
| | Improvements ✅ <br /> (secondary) | -0.4% | [-0.4%, -0.4%] | 2 | | ||
| | All ❌✅ (primary) | -0.2% | [-1.7%, 0.6%] | 3 | | ||
|
|
||
| - Only tiny changes, and the combined result is a wash. | ||
| - Marked as triaged. |