Merge pull request #1764 from rust-lang/deny-unused-ts

Deny unused variables and parameters in TypeScript/Vue
rust-lang · Dec 7, 2023 · 21fabf4 · 21fabf4
2 parents ddfd2b2 + 99d33e3
commit 21fabf4
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 15 deletions.
diff --git a/site/frontend/src/graph/render.ts b/site/frontend/src/graph/render.ts
@@ -210,7 +210,7 @@ function wheelZoomPlugin(opts) {
               });
             }
 
-            function onup(e) {
+            function onup(_e) {
               document.removeEventListener("mousemove", onmove);
               document.removeEventListener("mouseup", onup);
             }
@@ -294,7 +294,7 @@ function genPlotOpts({
     },
     scales: {
       y: {
-        range: (self, dataMin, dataMax) =>
+        range: (_self, dataMin, dataMax) =>
           uPlot.rangeNum(absoluteMode ? 0 : dataMin, dataMax, 0.2, true),
       },
     },
@@ -307,7 +307,7 @@ function genPlotOpts({
       {
         label: yAxisLabel,
         space: 24,
-        values: (self, splits) => {
+        values: (_self, splits) => {
           return splits.map((v) => {
             return v >= 1e12
               ? v / 1e12 + "T"
@@ -328,7 +328,7 @@ function genPlotOpts({
           drawAxes: [
             (u) => {
               let {ctx} = u;
-              let {left, top, width, height} = u.bbox;
+              let {top, height} = u.bbox;
 
               const interpolatedColorWithAlpha = "#fcb0f15f";
 
@@ -355,7 +355,7 @@ function genPlotOpts({
         },
       },
       tooltipPlugin({
-        onclick(u, seriesIdx, dataIdx) {
+        onclick(_u, _seriesIdx, dataIdx) {
           let thisCommit = commits[dataIdx][1];
           let prevCommit = (commits[dataIdx - 1] || [null, null])[1];
           window.open(

diff --git a/site/frontend/src/pages/bootstrap/plots.ts b/site/frontend/src/pages/bootstrap/plots.ts
@@ -140,14 +140,14 @@ function genPlotOpts({
       {
         label: yAxisLabel,
         space: 24,
-        values: (self, splits) => {
+        values: (_self, splits) => {
           return splits.map((v) => v / 1e9 + " sec");
         },
       },
     ],
     plugins: [
       tooltipPlugin({
-        onclick(u, seriesIdx, dataIdx) {
+        onclick(_u, _seriesIdx, dataIdx) {
           let thisCommit = commits[dataIdx][1];
           let prevCommit = (commits[dataIdx - 1] || [null, null])[1];
           window.open(`/compare.html?start=${prevCommit}&end=${thisCommit}`);

diff --git a/site/frontend/src/pages/compare/compile/table/comparisons-table.vue b/site/frontend/src/pages/compare/compile/table/comparisons-table.vue
@@ -7,7 +7,6 @@ import {CompileBenchmarkMap, CompileTestCase} from "../common";
 import {computed} from "vue";
 import {useExpandedStore} from "./expansion";
 import BenchmarkDetail from "./benchmark-detail.vue";
-import {getPastDate} from "./utils";
 
 const props = defineProps<{
   id: string;

diff --git a/site/frontend/src/pages/compare/metric-selector.vue b/site/frontend/src/pages/compare/metric-selector.vue
@@ -3,7 +3,6 @@ import {
   createUrlWithAppendedParams,
   navigateToUrlParams,
 } from "../../utils/navigation";
-import {BenchmarkInfo} from "../../api";
 import {MetricDescription} from "./metrics";
 
 const props = defineProps<{

diff --git a/site/frontend/src/pages/compare/summary/count.vue b/site/frontend/src/pages/compare/summary/count.vue
@@ -7,6 +7,6 @@ const props = defineProps<{
 
 <template>
   <span :title="cases + ' test case(s), ' + benchmarks + ' unique benchmark(s)'"
-    >{{ cases }} ({{ benchmarks }})</span
+    >{{ props.cases }} ({{ props.benchmarks }})</span
   >
 </template>
diff --git a/site/frontend/src/pages/compare/tabs.vue b/site/frontend/src/pages/compare/tabs.vue
@@ -1,5 +1,5 @@
 <script setup lang="tsx">
-import {computed, h, ref, Ref} from "vue";
+import {h, ref, Ref} from "vue";
 import {CompareResponse, Tab} from "./types";
 import {
   diffClass,

diff --git a/site/frontend/src/pages/status/page.vue b/site/frontend/src/pages/status/page.vue
@@ -2,7 +2,7 @@
 import {getJson} from "../../utils/requests";
 import {STATUS_DATA_URL} from "../../urls";
 import {withLoading} from "../../utils/loading";
-import {computed, ref, Ref, watch} from "vue";
+import {computed, ref, Ref} from "vue";
 import {
   Artifact,
   BenchmarkError,
@@ -16,10 +16,8 @@ import {
   differenceInSeconds,
   format,
   fromUnixTime,
-  sub,
   subSeconds,
 } from "date-fns";
-import {CompileTestCase} from "../compare/compile/common";
 import {useExpandedStore} from "./expansion";
 
 async function loadStatus(loading: Ref<boolean>) {

diff --git a/site/frontend/tsconfig.json b/site/frontend/tsconfig.json
@@ -7,6 +7,8 @@
     "rootDir": "src",
     "esModuleInterop": true,
     "jsx": "preserve",
-    "jsxFactory": "h"
+    "jsxFactory": "h",
+    "noUnusedLocals": true,
+    "noUnusedParameters": true
   }
 }