Add a CI workflow for performing rustc-pull automatically #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyouxu
added
A-CI
camelid
reviewed
Jan 9, 2025
|
I'm not sure if I'm the best person to review the overall PR, though, because I don't have experience with josh and our josh workflow. |
|
cc @BoxyUwU (I'll try to take a look, but I can't say I'm super familiar either lol) |
|
I don't really know how github CI files work but +1 to doing this and the rustc pull command seems like what I do locally so thats good :3 |
jieyouxu
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
I can't confirm this 100% works, but I looked at the workflow definition, and it seems reasonable to me. We'll have to actually use this in the real environment to see if we run into any hiccups in action (heh), so let's merge this and see.
Thanks for implementing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI workflow is configured to run weekly on Monday morning, and it can also be executed manually through
workflow_dispatch. The workflow runsrustc-pull, and if it actually pulled something, it force pushes to therustc-pullbranch, which is a sticky branch that should only be used for rustc pull updates.If there is an open PR created by the Github Actions bot, it will be updated by that push. If not, the workflow creates a new PR. This PR also opts this repo into the auto open/close PR functionality from triagebot, so that CI runs on pull requests opened by the GitHub Actions bot user.
The PR also adds explicit error messages if there is nothing to pull during
rustc-pull.This is how such a PR looks like.