Fix powerpc64 big-endian FreeBSD ABI #132150

taiki-e · 2024-10-25T20:00:25Z

Note that FreeBSD version bump may be reverted due to #120869 (comment). We may want to wait to merge this until that discussion is complete.

Fixes #120869 (comment)

PPC64 FreeBSD (ELFv1 and ELFv2, version 13.2)

It seems odd that ELFv1 and 13.N coexist.

https://www.freebsd.org/releases/13.0R/relnotes/

powerpc64 switched to ELFv2 ABI at the same time it switched to LLVM. This brings us to a parity with modern Linux distributions. This also makes the binaries from previous FreeBSD versions incompatible with 13.0-RELEASE. Kernel still supports ELFv1, so jails and chroots using older FreeBSD versions are still compatible. e4399d169acc

Well, it is also odd that this target claims ELFv2 support since our ABI code does not use ELFv2 on this target.

rust/compiler/rustc_target/src/callconv/powerpc64.rs

Lines 102 to 111 in be01dab

let abi = if cx.target_spec().env == "musl" {

ELFv2

} else if cx.target_spec().os == "aix" {

AIX

} else {

match cx.data_layout().endian {

Endian::Big => ELFv1,

Endian::Little => ELFv2,

}

};

@rustbot label +O-PowerPC +O-freebsd

rustbot · 2024-10-25T20:00:35Z

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-10-25T20:00:37Z

These commits modify compiler targets.
(See the Target Tier Policy.)

beetrees · 2024-10-25T21:01:34Z

FreeBSD ports already carries a patch with this effect, so this PR will make upstream Rust match what FreeBSD ports already does.

cc target maintainers from #129220: @asomers @MikaelUrankar

adalava · 2024-11-07T03:50:54Z

@taiki-e I can confirm that FreeBSD 13 (and also 14) powerpc64 (big-endian) kernel is compatible with both ELFv1 and ELFv2 and there's no plans to deprecate ELFv1 compatibility in the kernel at this moment. Users running 13/14 can jail or chroot to a sysroot from 12.x or 11.x to run their stuff. The package build servers (ports) generally uses the most recent kernel version and is able to build packages for FreeBSD 12/13/14 inside a Jail.

FreeBSD 12 is EOL since Dec/2023 so the project doesn't release ELFv1 binaries since then (sysroot, kernel and ports/packages). In case of Rust, I think it's up to Rust developers if it's too soon or not to deprecate ELFv1 now. We recommend users to upgrade but Rust may want keep supporting ELFv1 users for a while.

If you decide to keep both, I'd recommend decide the ABI based on OS major version retrieved from compiler's target triple: "powerpc64-unknown-freebsd12", "powerpc64-unknown-freebsd13", for instance, so ELFv1 if OS version <13 and ELFv2 by default. For the powerpc64le (little-endian) target it must be ELFv2 only.

This is how LLVM choose the ABI: llvm/llvm-project@8edf759#diff-bac41c71569f27df21a843bcd74d2e604ed508afbdf141777761dfb545c5d228R1919

taiki-e · 2024-11-07T04:10:42Z

@adalava We have decided to drop FreeBSD 12 support as discussed in the PR I linked to (#120869). That PR itself was reverted (#132228) due to another issue (#132185), but the decision itself there has not been reversed (#132228 (comment)).

pnkfelix · 2024-12-12T14:51:46Z

@bors r+

bors · 2024-12-12T14:51:48Z

@pnkfelix: 🔑 Insufficient privileges: Not in reviewers

pnkfelix · 2024-12-12T14:52:43Z

@pnkfelix: 🔑 Insufficient privileges: Not in reviewers

ha ha okay yeah I figured that might happen

pnkfelix · 2024-12-12T14:52:57Z

r? @rust-lang/compiler

apiraino · 2024-12-12T16:22:15Z

@bors r+

bors · 2024-12-12T16:22:18Z

📌 Commit fabf652 has been approved by apiraino

It is now in the queue for this repository.

apiraino · 2024-12-12T16:25:29Z

@bors r=pnkfelix

bors · 2024-12-12T16:25:34Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: add some debug-assertion crash tests #132789

bors · 2024-12-12T16:25:35Z

📌 Commit fabf652 has been approved by pnkfelix

It is now in the queue for this repository.

apiraino · 2024-12-12T16:43:22Z

@taiki-e when you have a chance, can you please rebase? this is good to go. thanks!

compiler-errors · 2024-12-12T16:44:46Z

@apiraino: it's already approved though?

taiki-e · 2024-12-12T16:55:02Z

@apiraino Rebased.

compiler-errors · 2024-12-12T16:58:26Z

@bors r=pnkfelix

bors · 2024-12-12T16:58:29Z

📌 Commit 3a90c47 has been approved by pnkfelix

It is now in the queue for this repository.

compiler-errors · 2024-12-13T00:40:33Z

@bors rollup

Fix powerpc64 big-endian FreeBSD ABI Note that FreeBSD version bump may be reverted due to rust-lang#120869 (comment). We may want to wait to merge this until that discussion is complete. Fixes rust-lang#120869 (comment) > > PPC64 FreeBSD (ELFv1 and ELFv2, version 13.2) > > It seems odd that ELFv1 and 13.N coexist. > > https://www.freebsd.org/releases/13.0R/relnotes/ > > > powerpc64 switched to ELFv2 ABI at the same time it switched to LLVM. This brings us to a parity with modern Linux distributions. This also makes the binaries from previous FreeBSD versions incompatible with 13.0-RELEASE. Kernel still supports ELFv1, so jails and chroots using older FreeBSD versions are still compatible. [e4399d169acc](https://cgit.freebsd.org/src/commit/?id=e4399d169acc) > > Well, it is also odd that this target claims ELFv2 support since our ABI code does not use ELFv2 on this target. > > https://github.com/rust-lang/rust/blob/be01dabfefd2daa4574b974f571c7852085d60cb/compiler/rustc_target/src/callconv/powerpc64.rs#L102-L111 `@rustbot` label +O-PowerPC +O-freebsd

…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#130060 (Autodiff Upstreaming - rustc_codegen_llvm changes) - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134208 (coverage: Tidy up creation of covmap and covfun records) - rust-lang#134209 (validate `--skip` and `--exclude` paths) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) - rust-lang#134227 (Update wasi-sdk used to build WASI targets) - rust-lang#134229 (Fix typos in docs on provenance) r? `@ghost` `@rustbot` modify labels: rollup

Fix powerpc64 big-endian FreeBSD ABI Note that FreeBSD version bump may be reverted due to rust-lang#120869 (comment). We may want to wait to merge this until that discussion is complete. Fixes rust-lang#120869 (comment) > > PPC64 FreeBSD (ELFv1 and ELFv2, version 13.2) > > It seems odd that ELFv1 and 13.N coexist. > > https://www.freebsd.org/releases/13.0R/relnotes/ > > > powerpc64 switched to ELFv2 ABI at the same time it switched to LLVM. This brings us to a parity with modern Linux distributions. This also makes the binaries from previous FreeBSD versions incompatible with 13.0-RELEASE. Kernel still supports ELFv1, so jails and chroots using older FreeBSD versions are still compatible. [e4399d169acc](https://cgit.freebsd.org/src/commit/?id=e4399d169acc) > > Well, it is also odd that this target claims ELFv2 support since our ABI code does not use ELFv2 on this target. > > https://github.com/rust-lang/rust/blob/be01dabfefd2daa4574b974f571c7852085d60cb/compiler/rustc_target/src/callconv/powerpc64.rs#L102-L111 ``@rustbot`` label +O-PowerPC +O-freebsd

Rollup of 9 pull requests Successful merges: - rust-lang#130060 (Autodiff Upstreaming - rustc_codegen_llvm changes) - rust-lang#132038 (Add lint rule for `#[deprecated]` on re-exports) - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133633 (don't show the full linker args unless `--verbose` is passed) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134208 (coverage: Tidy up creation of covmap and covfun records) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) Failed merges: - rust-lang#133099 (forbid toggling x87 and fpregs on hard-float targets) r? `@ghost` `@rustbot` modify labels: rollup

Fix powerpc64 big-endian FreeBSD ABI Note that FreeBSD version bump may be reverted due to rust-lang#120869 (comment). We may want to wait to merge this until that discussion is complete. Fixes rust-lang#120869 (comment) > > PPC64 FreeBSD (ELFv1 and ELFv2, version 13.2) > > It seems odd that ELFv1 and 13.N coexist. > > https://www.freebsd.org/releases/13.0R/relnotes/ > > > powerpc64 switched to ELFv2 ABI at the same time it switched to LLVM. This brings us to a parity with modern Linux distributions. This also makes the binaries from previous FreeBSD versions incompatible with 13.0-RELEASE. Kernel still supports ELFv1, so jails and chroots using older FreeBSD versions are still compatible. [e4399d169acc](https://cgit.freebsd.org/src/commit/?id=e4399d169acc) > > Well, it is also odd that this target claims ELFv2 support since our ABI code does not use ELFv2 on this target. > > https://github.com/rust-lang/rust/blob/be01dabfefd2daa4574b974f571c7852085d60cb/compiler/rustc_target/src/callconv/powerpc64.rs#L102-L111 ```@rustbot``` label +O-PowerPC +O-freebsd

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#132038 (Add lint rule for `#[deprecated]` on re-exports) - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133633 (don't show the full linker args unless `--verbose` is passed) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134208 (coverage: Tidy up creation of covmap and covfun records) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) r? `@ghost` `@rustbot` modify labels: rollup

Fix powerpc64 big-endian FreeBSD ABI Note that FreeBSD version bump may be reverted due to rust-lang#120869 (comment). We may want to wait to merge this until that discussion is complete. Fixes rust-lang#120869 (comment) > > PPC64 FreeBSD (ELFv1 and ELFv2, version 13.2) > > It seems odd that ELFv1 and 13.N coexist. > > https://www.freebsd.org/releases/13.0R/relnotes/ > > > powerpc64 switched to ELFv2 ABI at the same time it switched to LLVM. This brings us to a parity with modern Linux distributions. This also makes the binaries from previous FreeBSD versions incompatible with 13.0-RELEASE. Kernel still supports ELFv1, so jails and chroots using older FreeBSD versions are still compatible. [e4399d169acc](https://cgit.freebsd.org/src/commit/?id=e4399d169acc) > > Well, it is also odd that this target claims ELFv2 support since our ABI code does not use ELFv2 on this target. > > https://github.com/rust-lang/rust/blob/be01dabfefd2daa4574b974f571c7852085d60cb/compiler/rustc_target/src/callconv/powerpc64.rs#L102-L111 ````@rustbot```` label +O-PowerPC +O-freebsd

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#132038 (Add lint rule for `#[deprecated]` on re-exports) - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133633 (don't show the full linker args unless `--verbose` is passed) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) r? `@ghost` `@rustbot` modify labels: rollup

Fix powerpc64 big-endian FreeBSD ABI Note that FreeBSD version bump may be reverted due to rust-lang#120869 (comment). We may want to wait to merge this until that discussion is complete. Fixes rust-lang#120869 (comment) > > PPC64 FreeBSD (ELFv1 and ELFv2, version 13.2) > > It seems odd that ELFv1 and 13.N coexist. > > https://www.freebsd.org/releases/13.0R/relnotes/ > > > powerpc64 switched to ELFv2 ABI at the same time it switched to LLVM. This brings us to a parity with modern Linux distributions. This also makes the binaries from previous FreeBSD versions incompatible with 13.0-RELEASE. Kernel still supports ELFv1, so jails and chroots using older FreeBSD versions are still compatible. [e4399d169acc](https://cgit.freebsd.org/src/commit/?id=e4399d169acc) > > Well, it is also odd that this target claims ELFv2 support since our ABI code does not use ELFv2 on this target. > > https://github.com/rust-lang/rust/blob/be01dabfefd2daa4574b974f571c7852085d60cb/compiler/rustc_target/src/callconv/powerpc64.rs#L102-L111 `````@rustbot````` label +O-PowerPC +O-freebsd

Rollup of 4 pull requests Successful merges: - rust-lang#132038 (Add lint rule for `#[deprecated]` on re-exports) - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133633 (don't show the full linker args unless `--verbose` is passed) - rust-lang#133942 (Clarify how to use `black_box()`) r? `@ghost` `@rustbot` modify labels: rollup try-job: dist-x86_64-linux

Fix powerpc64 big-endian FreeBSD ABI Note that FreeBSD version bump may be reverted due to rust-lang#120869 (comment). We may want to wait to merge this until that discussion is complete. Fixes rust-lang#120869 (comment) > > PPC64 FreeBSD (ELFv1 and ELFv2, version 13.2) > > It seems odd that ELFv1 and 13.N coexist. > > https://www.freebsd.org/releases/13.0R/relnotes/ > > > powerpc64 switched to ELFv2 ABI at the same time it switched to LLVM. This brings us to a parity with modern Linux distributions. This also makes the binaries from previous FreeBSD versions incompatible with 13.0-RELEASE. Kernel still supports ELFv1, so jails and chroots using older FreeBSD versions are still compatible. [e4399d169acc](https://cgit.freebsd.org/src/commit/?id=e4399d169acc) > > Well, it is also odd that this target claims ELFv2 support since our ABI code does not use ELFv2 on this target. > > https://github.com/rust-lang/rust/blob/be01dabfefd2daa4574b974f571c7852085d60cb/compiler/rustc_target/src/callconv/powerpc64.rs#L102-L111 ``````@rustbot`````` label +O-PowerPC +O-freebsd

Fix powerpc64 big-endian FreeBSD ABI Note that FreeBSD version bump may be reverted due to rust-lang#120869 (comment). We may want to wait to merge this until that discussion is complete. Fixes rust-lang#120869 (comment) > > PPC64 FreeBSD (ELFv1 and ELFv2, version 13.2) > > It seems odd that ELFv1 and 13.N coexist. > > https://www.freebsd.org/releases/13.0R/relnotes/ > > > powerpc64 switched to ELFv2 ABI at the same time it switched to LLVM. This brings us to a parity with modern Linux distributions. This also makes the binaries from previous FreeBSD versions incompatible with 13.0-RELEASE. Kernel still supports ELFv1, so jails and chroots using older FreeBSD versions are still compatible. [e4399d169acc](https://cgit.freebsd.org/src/commit/?id=e4399d169acc) > > Well, it is also odd that this target claims ELFv2 support since our ABI code does not use ELFv2 on this target. > > https://github.com/rust-lang/rust/blob/be01dabfefd2daa4574b974f571c7852085d60cb/compiler/rustc_target/src/callconv/powerpc64.rs#L102-L111 ```````@rustbot``````` label +O-PowerPC +O-freebsd

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133633 (don't show the full linker args unless `--verbose` is passed) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134208 (coverage: Tidy up creation of covmap and covfun records) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#132150 (Fix powerpc64 big-endian FreeBSD ABI) - rust-lang#133942 (Clarify how to use `black_box()`) - rust-lang#134081 (Try to evaluate constants in legacy mangling) - rust-lang#134192 (Remove `Lexer`'s dependency on `Parser`.) - rust-lang#134208 (coverage: Tidy up creation of covmap and covfun records) - rust-lang#134211 (On Neutrino QNX, reduce the need to set archiver via environment variables) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132150 - taiki-e:ppc64-freebsd-abi, r=pnkfelix Fix powerpc64 big-endian FreeBSD ABI Note that FreeBSD version bump may be reverted due to rust-lang#120869 (comment). We may want to wait to merge this until that discussion is complete. Fixes rust-lang#120869 (comment) > > PPC64 FreeBSD (ELFv1 and ELFv2, version 13.2) > > It seems odd that ELFv1 and 13.N coexist. > > https://www.freebsd.org/releases/13.0R/relnotes/ > > > powerpc64 switched to ELFv2 ABI at the same time it switched to LLVM. This brings us to a parity with modern Linux distributions. This also makes the binaries from previous FreeBSD versions incompatible with 13.0-RELEASE. Kernel still supports ELFv1, so jails and chroots using older FreeBSD versions are still compatible. [e4399d169acc](https://cgit.freebsd.org/src/commit/?id=e4399d169acc) > > Well, it is also odd that this target claims ELFv2 support since our ABI code does not use ELFv2 on this target. > > https://github.com/rust-lang/rust/blob/be01dabfefd2daa4574b974f571c7852085d60cb/compiler/rustc_target/src/callconv/powerpc64.rs#L102-L111 ````````@rustbot```````` label +O-PowerPC +O-freebsd

rustbot assigned pnkfelix Oct 25, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2024

taiki-e mentioned this pull request Oct 25, 2024

ci update freebsd version proposal, freebsd 12 being eol #120869

Merged

rustbot added O-freebsd Operating system: FreeBSD O-PowerPC Target: PowerPC processors labels Oct 25, 2024

rustbot assigned chenyukang and unassigned pnkfelix Dec 12, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2024

Fix powerpc64 big-endian FreeBSD ABI

3a90c47

taiki-e force-pushed the ppc64-freebsd-abi branch from fabf652 to 3a90c47 Compare December 12, 2024 16:53

compiler-errors mentioned this pull request Dec 13, 2024

Rollup of 10 pull requests #134239

Closed

Zalathar mentioned this pull request Dec 13, 2024

Rollup of 9 pull requests #134245

Closed

matthiaskrgr mentioned this pull request Dec 13, 2024

Rollup of 8 pull requests #134249

Closed

matthiaskrgr mentioned this pull request Dec 13, 2024

Rollup of 7 pull requests #134257

Closed

matthiaskrgr mentioned this pull request Dec 13, 2024

Rollup of 4 pull requests #134266

Closed

matthiaskrgr mentioned this pull request Dec 13, 2024

Rollup of 7 pull requests #134282

Closed

Zalathar mentioned this pull request Dec 14, 2024

Rollup of 10 pull requests #134289

Closed

matthiaskrgr mentioned this pull request Dec 14, 2024

Rollup of 6 pull requests #134296

Merged

bors merged commit 71ee12c into rust-lang:master Dec 14, 2024
6 checks passed

rustbot added this to the 1.85.0 milestone Dec 14, 2024

taiki-e deleted the ppc64-freebsd-abi branch December 14, 2024 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix powerpc64 big-endian FreeBSD ABI #132150

Fix powerpc64 big-endian FreeBSD ABI #132150

taiki-e commented Oct 25, 2024 •

edited

Loading

rustbot commented Oct 25, 2024

rustbot commented Oct 25, 2024

beetrees commented Oct 25, 2024 •

edited

Loading

adalava commented Nov 7, 2024

taiki-e commented Nov 7, 2024

pnkfelix commented Dec 12, 2024

bors commented Dec 12, 2024

pnkfelix commented Dec 12, 2024

pnkfelix commented Dec 12, 2024

apiraino commented Dec 12, 2024

bors commented Dec 12, 2024

apiraino commented Dec 12, 2024

bors commented Dec 12, 2024

bors commented Dec 12, 2024

apiraino commented Dec 12, 2024

compiler-errors commented Dec 12, 2024

taiki-e commented Dec 12, 2024

compiler-errors commented Dec 12, 2024

bors commented Dec 12, 2024

compiler-errors commented Dec 13, 2024

	let abi = if cx.target_spec().env == "musl" {
	ELFv2
	} else if cx.target_spec().os == "aix" {
	AIX
	} else {
	match cx.data_layout().endian {
	Endian::Big => ELFv1,
	Endian::Little => ELFv2,
	}
	};

Fix powerpc64 big-endian FreeBSD ABI #132150

Fix powerpc64 big-endian FreeBSD ABI #132150

Conversation

taiki-e commented Oct 25, 2024 • edited Loading

rustbot commented Oct 25, 2024

rustbot commented Oct 25, 2024

beetrees commented Oct 25, 2024 • edited Loading

adalava commented Nov 7, 2024

taiki-e commented Nov 7, 2024

pnkfelix commented Dec 12, 2024

bors commented Dec 12, 2024

pnkfelix commented Dec 12, 2024

pnkfelix commented Dec 12, 2024

apiraino commented Dec 12, 2024

bors commented Dec 12, 2024

apiraino commented Dec 12, 2024

bors commented Dec 12, 2024

bors commented Dec 12, 2024

apiraino commented Dec 12, 2024

compiler-errors commented Dec 12, 2024

taiki-e commented Dec 12, 2024

compiler-errors commented Dec 12, 2024

bors commented Dec 12, 2024

compiler-errors commented Dec 13, 2024

taiki-e commented Oct 25, 2024 •

edited

Loading

beetrees commented Oct 25, 2024 •

edited

Loading