clarify message for non-obvious precedence #14043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Centri3
reviewed
Jan 22, 2025
clippy_lints/src/precedence.rs
Outdated
| @@ -43,7 +43,7 @@ impl EarlyLintPass for Precedence { | |||
| cx, | |||
| PRECEDENCE, | |||
| expr.span, | |||
| "operator precedence can trip the unwary", | |||
| "operator precedence may not be obvious", | |||
There was a problem hiding this comment.
If we're gonna be really pedantic, this could also be read as if it is not allowed to be obvious. I prefer this, but If we're here already, I'd say to use might not instead
There was a problem hiding this comment.
Nice catch; you're absolutely right. I've changed it to "might not".
Centri3
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across this message while writing code and thought it was quite odd. I've simplified it and hopefully made it clearer for non-native English speakers.
changelog: clarify message for non-obvious precedence