change literal_string_with_formatting_args lint category to nursery

[anatawa12]

This PR changes literal_string_with_formatting_args category from suspicious to nursery since there are thousands of false positive on GitHub.

Closes #13989 since it's no longer problematic with such false positive with pedantic nursery category.

changelog: [literal_string_with_formatting_args ] change category to nursery from suspicious

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[samueltardieu]

Note that most of those false positives should be fixed by #13953.

[GuillaumeGomez]

Let's check what false positives remain once #13953 is merged indeed. The remaining ones might still be bugs.

[anatawa12]

I tried #13953 (277bf08) and I can see false positive cause I showed in #13989 is not fixed by #13953

[y21]

I'm of the same opinion that we should probably change this lint's category for the time being even if the PR fixes some of them. It's already in beta and some of the bugs don't seem to have an obvious fix and probably require some "design work" (e.g. the ones involving .replace("{var}", var) -- it's not technically wrong that it looks like a format string but thousands of false positives is too much IMO). I don't know about pedantic though - typically the category for buggy lints is nursery. People do use #![warn(clippy::pedantic)].

There's nothing wrong with having it in nursery temporarily, but having it warn-by-default while it's buggy means lots of people will allow the lint and will later not catch potential errors.

[Alexendoo]

I agree, let's put it in nursery until we're confident the true positives significantly outweigh the false ones

[GuillaumeGomez]

Didn't think about moving it to nursery. Good idea.

[anatawa12]

I thought pedantic lints have many false positives, but I checked existing lints now and I saw those are much less possibility for false positives than this so I agree with change to nursery. I made this PR to change to nursery.