Suggest using Vec::extend() in same_item_push
#13987
Merged
+66
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
xFrednet
reviewed
Jan 15, 2025
| @@ -50,6 +50,16 @@ fn main() { | |||
| //~^ ERROR: it looks like the same item is being pushed into this Vec | |||
| } | |||
|
|
|||
| #[clippy::msrv = "1.81"] | |||
There was a problem hiding this comment.
Please make sure to also add the lint to the configuration:
rust-clippy/clippy_config/src/conf.rs
Lines 649 to 651 in 25d319d
There was a problem hiding this comment.
I always forget that users may configure the msrv in Clippy as well, thanks for the reminder!
There was a problem hiding this comment.
If you want a project, you can try to find a way to do this automatically. This has been something like a holly grail for some time. ^^
Using `Vec::extend(std::iter::repeat_n(item, N))` allows to use the more natural number of elements to add `N`, as is probably done in the original loop, instead of computing the difference between the existing number of elements and the wanted one. Before MSRV 1.82, the older suggestion to use `Vec::resize()` is still issued.
samueltardieu
force-pushed
the
push-rwtrylsmrlyt
branch
from
b90338f to
ded9354
Compare
xFrednet
approved these changes
Jan 22, 2025
|
LGTM, thanks for the addition. (And sorry for the delay with my review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Vec::extend(std::iter::repeat_n(item, N))allows to use the more natural number of elements to addN, as is probably done in the original loop, instead of computing the difference between the existing number of elements and the wanted one.Before MSRV 1.82, the older suggestion to use
Vec::resize()is still issued.Inspired by #6156 (which predates
repeat_n()).changelog: [
same_item_push]: recommend usingVec::extend()to extend a vector