Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Publish test-fixture => ra_ap_test_fixture #18437

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

sam-mccall
Copy link
Contributor

Currently it's possible to build rust-analyzer from the ra_ap crates, but not
possible to build their tests, as test-fixture isn't published.

If there isn't a particular reason to exclude this crate, I'd like to publish
it so that tests can be built and run from crates.io sources.

Context: I'm importing rust-analyzer code into a non-cargo build environment
(using Bazel). We'd prefer to import from crates.io for uniformity with other
libraries, and to build and run all tests to make sure we didn't break anything.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2024
@Veykril Veykril added this pull request to the merge queue Oct 31, 2024
Merged via the queue into rust-lang:master with commit fb8ca32 Oct 31, 2024
9 checks passed
@lnicola lnicola changed the title Publish test-fixture => ra_ap_test_fixture internal: Publish test-fixture => ra_ap_test_fixture Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants