feat: Report document symbols of kind variable
for let statements
#18312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initially i had implemented a bunch more kinds, but eventually realized that
ide_db::SymbolKind
!=lsp_types::SymbolKind
and that many of the former kind are mapped to the same latter kind, which could cause annoyances when e.g. the user wants their outline view in vscode to showide_db::SymbolKind::Const
andide_db::SymbolKind::Static
but notide_db::SymbolKind::ConstParam
(which wouldn't be possible to configure in vscode since all of them are mapped tolsp_types::SymbolKind::CONSTANT
) so i decided to take a conservative approach and ended up removing all but 1 kind