Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Simplify #16704

Merged
merged 3 commits into from
Mar 2, 2024
Merged

internal: Simplify #16704

merged 3 commits into from
Mar 2, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 28, 2024

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2024
@Veykril
Copy link
Member Author

Veykril commented Feb 28, 2024

@bors r+

Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions for recording values as standalone fields.

lib/lsp-server/src/stdio.rs Show resolved Hide resolved
crates/rust-analyzer/src/handlers/notification.rs Outdated Show resolved Hide resolved
@Veykril
Copy link
Member Author

Veykril commented Feb 29, 2024

@bors r+

@Veykril Veykril force-pushed the stuff branch 2 times, most recently from 93cfef1 to 2408c39 Compare March 1, 2024 12:22
@Veykril
Copy link
Member Author

Veykril commented Mar 1, 2024

@bors r+

@Veykril
Copy link
Member Author

Veykril commented Mar 1, 2024

@bors r+

1 similar comment
@Veykril
Copy link
Member Author

Veykril commented Mar 2, 2024

@bors r+

@Veykril
Copy link
Member Author

Veykril commented Mar 2, 2024

@bors ping

@Veykril Veykril closed this Mar 2, 2024
@Veykril Veykril reopened this Mar 2, 2024
@Veykril
Copy link
Member Author

Veykril commented Mar 2, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 2, 2024

📌 Commit ed7e9aa has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 2, 2024

⌛ Testing commit ed7e9aa with merge 5c4c126...

@bors
Copy link
Contributor

bors commented Mar 2, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 5c4c126 to master...

@bors bors merged commit 5c4c126 into rust-lang:master Mar 2, 2024
21 checks passed
@Veykril Veykril deleted the stuff branch September 9, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants