Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix completions panicking with certain macro setups #16691

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 27, 2024

Unable to figure out a test case for this but managed to run into it in r-a reproducably.

Fixes #16266 Fixes #13255

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2024
@Veykril
Copy link
Member Author

Veykril commented Feb 27, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Feb 27, 2024

📌 Commit cc7fe32 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 27, 2024

⌛ Testing commit cc7fe32 with merge d4d9d0c...

@bors
Copy link
Contributor

bors commented Feb 27, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing d4d9d0c to master...

@bors bors merged commit d4d9d0c into rust-lang:master Feb 27, 2024
11 checks passed
@Veykril Veykril deleted the completion-analysis-panic branch September 9, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thread 'Worker' panicked Failed to lookup [email protected] in this Semantics.
3 participants