Narrow down typos ignores #16673
Narrow down typos ignores #16673
Conversation
szepeviktor
commented
Feb 25, 2024
•
szepeviktor
commented
- remove ignored files
- check dotfiles
- reorder config sections: files, regexp, words, IDs
- remove non-existent ignores
rustbot
added
the
S-waiting-on-review
|
💡 It would be nice to rename plural Latin variables names.
|
| "*.rast", | ||
| "crates/parser/test_data/lexer/err/*", |
There was a problem hiding this comment.
these are auto generated, IMO they should be exclude, since other typos occur here in the furture
.typos.toml
Outdated
| '"flate2"', | ||
| 'IDENT "SER"', | ||
| "raison d'être", |
There was a problem hiding this comment.
I don't think extend-ignore-re is the rigth place for them
There was a problem hiding this comment.
words and identifiers couldn't help here, e.g. adding SER to identifiers will hide future typos of "SET"
Young-Flash
added
S-waiting-on-author
.typos.toml
Outdated
| "bench_data/*", | ||
| ] | ||
| [default.extend-identifiers] | ||
| 0onoDigit = "0onoDigit" |
.typos.toml
Outdated
| # ignore generated content like `boxed....nner()`, `Defaul...efault` | ||
| "\\w*\\.{3,4}\\w*", | ||
| '"flate2"', | ||
| 'IDENT "SER"', |
There was a problem hiding this comment.
Same for this one? And we could also ignore crates/project-model/test_data/*, I don't think there's anything useful in there.
And would you mind squashing at the end?
There was a problem hiding this comment.
As you wish.
Now comes the squashing ...
|
Thanks! @bors r+ |
|
Glad to contribute. |
|
☀️ Test successful - checks-actions |
