fix: replace_filter_map_next_with_find_map shouldn't work for dyn trait #16647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Young-Flash
force-pushed
the
fix_replace_filter_map_next_with_find_map
branch
from
d9dedbd to
0978d16
Compare
Veykril
reviewed
Feb 26, 2024
| self.diagnostics.push(BodyValidationDiagnostic::ReplaceFilterMapNextWithFindMap { | ||
| method_call_expr: call_id, | ||
| }); | ||
| } | ||
|
|
||
| let receiver_ty = self.infer[*receiver].strip_references().clone(); |
There was a problem hiding this comment.
Why are we stripping it here? If this is due to coercions and autoref then we should check the adjustments:
let coerced = self.infer
.expr_adjustments
.get(receiver)
.and_then(|adjusts| adjusts.last().map(|adjust| adjust.target.clone()));There was a problem hiding this comment.
Ah nvm you want to get the dyn trait, then we should do the stripping where we check for the dyn trait, that seems more proper.
Veykril
added
S-waiting-on-author
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Feb 26, 2024
…ind_map, r=Veykril fix: replace_filter_map_next_with_find_map shouldn't work for dyn trait close #16596
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #16596