fix: Correctly set and mark the proc-macro spans #16175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
commented
Dec 21, 2023
crates/hir-def/src/db.rs
Outdated
Comment on lines
338
to
340
| def_site: db | ||
| .span_map(loc.id.file_id()) | ||
| .span_for_range(db.ast_id_map(loc.id.file_id()).get(makro.ast_id).text_range()), |
There was a problem hiding this comment.
slow down comes from this, which I assume misses the cache for the span maps in some occurrences unfortunately
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slows down analysis by 2-3s on self for me unfortunately (~2.5% slowdown)
Noisy diff due to two simple refactoring in the first 2 commits. Relevant changes are 7d762d1 and 1e1113c which introduce def site spans and correct marking for proc-macros respectively.