feat: Implement a rust-analyzer span backed proc-macro server mode #16088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
proc-macro-srv-2
branch
4 times, most recently
from
f3543fc to
9c66d9f
Compare
|
☔ The latest upstream changes (presumably #16144) made this pull request unmergeable. Please resolve the merge conflicts. |
Veykril
force-pushed
the
proc-macro-srv-2
branch
from
9c66d9f to
81928c9
Compare
Veykril
commented
Dec 22, 2023
| @@ -770,3 +771,15 @@ fn option_env_expand( | |||
|
|
|||
| ExpandResult::ok(expanded) | |||
| } | |||
|
|
|||
| fn quote_expand( | |||
There was a problem hiding this comment.
This is a very interesting macro, it's a builtin macro that is actually backed by a proc-macro that rustc loads from the proc_macro library https://doc.rust-lang.org/proc_macro/fn.quote.html! Unsure how we can hook that up for now, but that might require this part to be nightly gated as well
Veykril
force-pushed
the
proc-macro-srv-2
branch
3 times, most recently
from
0b02ea2 to
cf68a95
Compare
Veykril
force-pushed
the
proc-macro-srv-2
branch
from
cf68a95 to
9e8e124
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the basic span APIs. Basically anything that doesn't require talking back to the client for information access.
This also commits our syntax fixup marker to use an
ErasedAstFileIdof!0-1aka0xffff_fffe, instead of using a dummy FileId as a marker, as we need that for theSourceFileAPI to be implementable. The reason as to why the server needs to know about this at all is to prevent it from creating invalid fixup spans which could make r-a panic.