fix: fix type inference with IndexMut returning references
#16085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Austaras
commented
Dec 11, 2023
| &[index_ty.clone().cast(Interner)], | ||
| ); | ||
|
|
||
| if *is_assignee_expr { |
There was a problem hiding this comment.
It does no harm to obligate every indexing for IndexMut because r-a currently only save obligation that can be solved and it won't need an extra field in HIR, but I believe it's better to be more precise.
Austaras
force-pushed
the
master
branch
2 times, most recently
from
9d03293 to
6e3f928
Compare
Veykril
approved these changes
Jan 3, 2024
|
Thanks! |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
IndexMut when inferIndexMut returning references
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15842.
This issue arises because
Kis ambiguous if only inferred fromIndextrait, but is unique if inferred fromIndexMut, but r-a doesn't use this info.