Skip to content

Commit

Permalink
Add comments regarding workspace structure change querying
Browse files Browse the repository at this point in the history
  • Loading branch information
Veykril committed Aug 10, 2024
1 parent 6869b30 commit 1829460
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions crates/rust-analyzer/src/global_state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,11 @@ impl GlobalState {
}
}

// FIXME: `workspace_structure_change` is computed from `should_refresh_for_change` which is
// path syntax based. That is not sufficient for all cases so we should lift that check out
// into a `QueuedTask`, see `handle_did_save_text_document`.
// Or maybe instead of replacing that check, kick off a semantic one if the syntactic one
// didn't find anything (to make up for the lack of precision).
{
if !matches!(&workspace_structure_change, Some((.., true))) {
_ = self
Expand Down
2 changes: 2 additions & 0 deletions crates/rust-analyzer/src/handlers/notification.rs
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ pub(crate) fn handle_did_save_text_document(
.map(|cfg| cfg.files_to_watch.iter().map(String::as_str).collect::<Vec<&str>>())
.unwrap_or_default();

// FIXME: We should move this check into a QueuedTask and do semantic resolution of
// the files. There is only so much we can tell syntactically from the path.
if reload::should_refresh_for_change(path, ChangeKind::Modify, additional_files) {
state.fetch_workspaces_queue.request_op(
format!("workspace vfs file change saved {path}"),
Expand Down
1 change: 1 addition & 0 deletions crates/rust-analyzer/src/main_loop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ pub(crate) enum Task {
FetchWorkspace(ProjectWorkspaceProgress),
FetchBuildData(BuildDataProgress),
LoadProcMacros(ProcMacroProgress),
// FIXME: Remove this in favor of a more general QueuedTask, see `handle_did_save_text_document`
BuildDepsHaveChanged,
}

Expand Down

0 comments on commit 1829460

Please sign in to comment.