Skip to content

Commit

Permalink
resolve mislabled FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
lvllvl committed Jan 12, 2025
1 parent 699a51a commit de8da76
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions libc-test/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ fn test_windows(target: &str) {
// Just pass all these through, no need for a "struct" prefix
"FILE" | "DIR" | "Dl_info" => ty.to_string(),

// FIXME(ctest): these don't exist:
// FIXME(windows): these don't exist:
"time64_t" => "__time64_t".to_string(),
"ssize_t" => "SSIZE_T".to_string(),

Expand Down Expand Up @@ -712,7 +712,7 @@ fn test_windows(target: &str) {
cfg.skip_type(move |name| match name {
"SSIZE_T" if !gnu => true,
"ssize_t" if !gnu => true,
// FIXME(ctest): The size and alignment of this type are incorrect
// FIXME(windows): The size and alignment of this type are incorrect
"time_t" if gnu && i686 => true,
_ => false,
});
Expand All @@ -730,7 +730,7 @@ fn test_windows(target: &str) {

cfg.skip_const(move |name| {
match name {
// FIXME(ctest): API error:
// FIXME(windows): API error:
// SIG_ERR type is "void (*)(int)", not "int"
"SIG_ERR" |
// Similar for SIG_DFL/IGN/GET/SGE/ACK
Expand All @@ -745,7 +745,7 @@ fn test_windows(target: &str) {
"CONTEXT" if field == "Fp" => true,
_ => false,
});
// FIXME(ctest): All functions point to the wrong addresses?
// FIXME(windows): All functions point to the wrong addresses?
cfg.skip_fn_ptrcheck(|_| true);

cfg.skip_signededness(move |c| {
Expand Down Expand Up @@ -1041,7 +1041,7 @@ fn test_solarish(target: &str) {
// are still ABI compatible. We can wait for the next major release
// to be compliant with the new API.
//
// FIXME(ctest): unskip these for next major release
// FIXME(solarish): unskip these for next major release
"setpriority" | "personality" => true,

// signal is defined in terms of sighandler_t, so ignore
Expand Down Expand Up @@ -1222,7 +1222,7 @@ fn test_netbsd(target: &str) {
return true;
}
match ty {
// FIXME(ctest): sighandler_t is crazy across platforms
// FIXME(netbsd): sighandler_t is crazy across platforms
"sighandler_t" => true,
_ => false,
}
Expand Down Expand Up @@ -2750,7 +2750,7 @@ fn test_freebsd(target: &str) {
// anonymous struct
("devstat", "dev_links") => true,

// FIXME(ctest): structs too complicated to bind for now...
// FIXME(freebsd): structs too complicated to bind for now...
("kinfo_proc", "ki_paddr") => true,
("kinfo_proc", "ki_addr") => true,
("kinfo_proc", "ki_tracep") => true,
Expand Down Expand Up @@ -2931,7 +2931,7 @@ fn test_emscripten(target: &str) {
// This is actually a union, not a struct
"sigval" => true,

// FIXME(ctest): Investigate why the test fails.
// FIXME(emscripten): Investigate why the test fails.
// Skip for now to unblock CI.
"pthread_condattr_t" => true,
"pthread_mutexattr_t" => true,
Expand Down

0 comments on commit de8da76

Please sign in to comment.