This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
Adding Payload class to manage access to webhook payload #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a class --
Payload
-- to manage the access to the payload contents. At this point, it looks completely superfluous since all it's doing is forcing a bunch of changes in how we index into the payload, but this is setting the stage for further work on #72, which is going to require changes in the payload behavior.Previously we would index the payload like you normally index into a dict:
payload['a']['b']['c']
. In thePayload
object you index aspayload['a', 'b', 'c']
.A syntactically nicer alternative involves using properties (e.g.,
payload.a.b.c
). I implemented this first, but it was quite a bit more code, although it did have other niceties. I could make it shorter, but then decided to keep it simple. For that implementation, you can see thePayload
class here and it being used here, for example.