Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size information on crate details page #2659

Merged
merged 4 commits into from
Nov 2, 2024

Conversation

GuillaumeGomez
Copy link
Member

Fixes #2658.

It looks like this:

image

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner October 31, 2024 17:47
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 31, 2024
@GuillaumeGomez
Copy link
Member Author

Seems like I successfully updated the sqlx file. 😅

@GuillaumeGomez
Copy link
Member Author

CI passed. \o/

Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@GuillaumeGomez
Copy link
Member Author

Improved the SQL query and added the test.

@syphar syphar merged commit 2b767dc into rust-lang:master Nov 2, 2024
11 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 2, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 2, 2024
@GuillaumeGomez GuillaumeGomez deleted the size-crate-details branch November 2, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show documentation & source size on crate-detail page
2 participants