Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle S3 "KeyTooLongError" as PathNotFoundError in storage #2386

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Jan 17, 2024

in sentry we are seeing a new error from S3:

Unhandled

unhandled error (KeyTooLongError)

ErrorMetadata

Error { code: "KeyTooLongError", message: "Your key is too long", s3_extended_request_id: "8hzp1Kv7cGOsjW3EUaqBxaI8krQbNJYFX1UZdb5DzKsKpHG7B1K9rvRATlrT/MHw3kPtIbLIn9fEdGUrm85/Uw==", aws_request_id: "16PF5FB54MZZ081Q" }

it happens when the path in the requested URL is too long, and IMO should be seen as the same as a 404 from S3.

@syphar syphar requested a review from a team as a code owner January 17, 2024 10:19
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jan 17, 2024
@syphar syphar requested a review from Nemo157 January 17, 2024 14:41
@syphar syphar merged commit 7667f34 into rust-lang:master Jan 17, 2024
13 checks passed
@syphar syphar deleted the update-latest-version-id branch January 17, 2024 15:39
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jan 17, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants