Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show documentation & source size on crate-detail page #2658

Closed
syphar opened this issue Oct 31, 2024 · 3 comments · Fixed by #2659
Closed

show documentation & source size on crate-detail page #2658

syphar opened this issue Oct 31, 2024 · 3 comments · Fixed by #2659
Labels
E-easy Effort: Should be easy to implement and would make a good first PR

Comments

@syphar
Copy link
Member

syphar commented Oct 31, 2024 •
edited
Loading

The sizes we started collecting in #2644

on this page: https://docs.rs/crate/itertools/latest

I could imagine showing just the doc & source size for the latest build, perhaps similar to coverage?
@syphar syphar added the E-easy Effort: Should be easy to implement and would make a good first PR label Oct 31, 2024
@GuillaumeGomez
Copy link
Member

I think it makes more sense to only show it for the last version.

@syphar
Copy link
Member Author

syphar commented Oct 31, 2024

you mean the latest build?

the crate-detail page is version specific, so we would show the size of that version, if available

@GuillaumeGomez
Copy link
Member

Ah right, forgot about that. Then sure. Sending a PR.

@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 31, 2024
Merged
@robo9k robo9k mentioned this issue Nov 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Effort: Should be easy to implement and would make a good first PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add size information on crate details page GuillaumeGomez/docs.rs
2 participants
@syphar @GuillaumeGomez