Skip to content

Commit

Permalink
allow longer crate names & versions in build queue
Browse files Browse the repository at this point in the history
  • Loading branch information
syphar committed Oct 15, 2024
1 parent d4641c3 commit 1943e68
Show file tree
Hide file tree
Showing 6 changed files with 50 additions and 6 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
DELETE FROM queue WHERE LENGTH(name) > 255 OR LENGTH(version) > 100;

ALTER TABLE queue
ALTER COLUMN name TYPE VARCHAR(255),
ALTER COLUMN version TYPE VARCHAR(100);
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ALTER TABLE queue
ALTER COLUMN name TYPE TEXT,
ALTER COLUMN version TYPE TEXT;
36 changes: 36 additions & 0 deletions src/build_queue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1155,4 +1155,40 @@ mod tests {
Ok(())
});
}

#[test]
fn test_add_long_name() {
crate::test::wrapper(|env| {
let queue = env.build_queue();

let name: String = "krate".repeat(100);

queue.add_crate(&name, "0.0.1", 0, None)?;

queue.process_next_crate(|krate| {
assert_eq!(name, krate.name);
Ok(BuildPackageSummary::default())
})?;

Ok(())
})
}

#[test]
fn test_add_long_version() {
crate::test::wrapper(|env| {
let queue = env.build_queue();

let version: String = "version".repeat(100);

queue.add_crate("krate", &version, 0, None)?;

queue.process_next_crate(|krate| {
assert_eq!(version, krate.version);
Ok(BuildPackageSummary::default())
})?;

Ok(())
})
}
}

0 comments on commit 1943e68

Please sign in to comment.