follow up to rust-lang/crater#760, fix parsing FailureReason::Docker from string #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skgland
changed the title
pietroalbini
approved these changes
Jan 16, 2025
|
I was waiting for a local minicrater test run to finish, which is now done. |
|
I would expect this to only have impacted the report generation. Would it be possible to re-generate the report of the crater run once this is deployed? |
|
Unfortunately no :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the crater run rust-lang/rust#135511 (comment) had no spurious-regressions due to docker. Turns out in #760 I forgot to update the parsing of
FailureReasonafter adding theDockervariant.