Remove r2d2-sqlite #749
Merged
Remove r2d2-sqlite #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
force-pushed
the
debug-crater
branch
2 times, most recently
from
2207774 to
80b0ee1
Compare
r2d2-sqlite opens connections in shared cache mode: https://github.com/ivanceras/r2d2-sqlite/blob/06aa366cfe0846e491550b7e177ca0024bf923a9/src/lib.rs#L141 Per documentation (https://www.sqlite.org/sharedcache.html#dontuse), this is discouraged. In practice the dependency is trivially replaceable anyway.
Mark-Simulacrum
force-pushed
the
debug-crater
branch
from
80b0ee1 to
891d9df
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fbstj
reviewed
Dec 7, 2024
| } | ||
|
|
||
| fn has_broken(&self, conn: &mut Self::Connection) -> bool { | ||
| self.is_valid(conn).is_ok() |
There was a problem hiding this comment.
Yeah, good catch. I'll get it fixed in the next PR.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r2d2-sqlite opens connections in shared cache mode: https://github.com/ivanceras/r2d2-sqlite/blob/06aa366cfe0846e491550b7e177ca0024bf923a9/src/lib.rs#L141
Per documentation (https://www.sqlite.org/sharedcache.html#dontuse), this is discouraged. In practice the dependency is trivially replaceable anyway.