Fix UnselectedProjectionTy
parameters
#84
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems with how
UnselectedProjectionTy
parameters where handled:Firstly, they were in the wrong order with respect to those of
ProjectionTy
, i.e. the bound parameters of the associated type value should come first, then theSelf
type should come. For example, given:we would issue clauses like
UnselectedNormalize('a::Item<T> -> Ref<'a, T>) :- ...
instead ofUnselectedNormalize(T::Item<'a> -> Ref<'a, T>) :- ...
.Secondly, if the trait ref had any more parameters (in addition of the
Self
parameter), we would add those extra parameters to theUnselectedNormalize
clause inir::AssociatedTyValue::to_program_clauses
. For example, given:we would issue clauses like
UnselectedNormalize(T::Item<U> -> T) :- ...
instead ofUnselectedNormalize(T::Item -> T) :- ...
.This would eventually give
zipping things of mixed type
panics. Fixes #70.