replace !Vec::is_empty() then Some(Vec) with bool::then() #14516
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
A-cli
srtnnm
changed the title
| @@ -80,23 +80,15 @@ pub fn exec(gctx: &mut GlobalContext, args: &ArgMatches) -> CliResult { | |||
| compile_opts.build_config.requested_profile = InternedString::new("dev"); | |||
| } | |||
| let target_args = values(args, "args"); | |||
| compile_opts.target_rustc_args = if target_args.is_empty() { | |||
There was a problem hiding this comment.
It has to be wrapped with additional parentheses so doesn't seem more readable to me. The clippy lint if_then_some_else_none also only hints for the pattern of if-some-else-none not for the reversed.
Is there any other purpose of this change? Otherwise I tend to close this. Thank you.
There was a problem hiding this comment.
Agreed, I've found that if ! is used, I would rather have an if / else if
|
☔ The latest upstream changes (presumably #14499) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Thank you. I am going to close this. See #14516 (comment). |
What does this PR try to resolve?
None of existing issues.
Just replace if !vec.is_empty() {Some(vec)} with (!vec.is_empty()).then(|| vec) in src/bin/cargo/commands/rustc.rs
looks a little better i think