Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fields to be omitted in registry index metadata #14491

Closed
wants to merge 1 commit into from

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented Sep 4, 2024

This allows omission of some fields in the index metadata where there's an obvious default matching default of Cargo.toml.

  • In the future, for crates with high enough MSRV, crates.io could omit these fields to save a few bytes in the index.
  • It makes it a bit easier to implement custom registries, e.g. having to specify "optional": false for every dependency seems unnecessary, and having to emit features: {} when using features2 is surprising.

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-registries Area: registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2024
@epage
Copy link
Contributor

epage commented Sep 4, 2024

This requires an issue, maybe even an RFC. Closing until this has been approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-registries Area: registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants