Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize ExactlyOneError::fold #826

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Specialize ExactlyOneError::fold #826

merged 2 commits into from
Dec 16, 2023

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented Dec 15, 2023 •
edited
Loading

Related to #755

cargo bench --bench specializations "exactly_one_error/fold"

exactly_one_error/fold  [568.69 ns 570.74 ns 572.99 ns]
exactly_one_error/fold  [268.29 ns 268.52 ns 268.78 ns]
                        [-52.687% -52.402% -52.141%]

EDIT: Apparently, I previously forgot the specialization test.

@Philippe-Cholet Philippe-Cholet added this to the next milestone Dec 15, 2023
phimuemue
phimuemue approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@phimuemue phimuemue added this pull request to the merge queue Dec 16, 2023
Merged via the queue into rust-itertools:master with commit a90f095 Dec 16, 2023
8 checks passed
@Philippe-Cholet Philippe-Cholet deleted the fold-exactly1error branch December 16, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phimuemue phimuemue phimuemue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Philippe-Cholet @phimuemue