Add support for passing empty strings from Kotlin to Rust #756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we couldn't pass empty strings from Kotlin to Rust. This is because string passing from Kotlin to Rust involves the allocation of a JNA
Memory
object, which can't be creating with a size of zero, so passing an empty string results in a runtime exception.In this PR, we add support for passing empty strings from Kotlin to Rust. This is done by casing out
Memory
allocation so that if the allocated size is zero we actually allocate a size of 1, and then clear it.Fixes #749