Refactor C2 backend to produce Header objects #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was necessary when generating a type had a bunch of impl-to-decl and impl-to-result-header deps, but that is no longer the case and we can simplify things. We can reintroduce a HeaderContext if we need in the future.
Manishearth
commented
Jun 8, 2024
| _ => unreachable!("unknown AST/HIR variant"), | ||
| }; | ||
| // Todo(breaking): We can remove this requirement | ||
| // and users will be forced to import more types | ||
| if let Some(id) = id { |
There was a problem hiding this comment.
this is the main actual behavioral change here. Foo.h no longer imports all impl header files for its method dependencies
Manishearth
commented
Jun 8, 2024
| @@ -1,7 +1,11 @@ | |||
| #include <stdio.h> | |||
| #include <assert.h> | |||
|
|
|||
| #include "include/ICU4XLocale.h" | |||
There was a problem hiding this comment.
(this is because of the change at the bottom of ty.rs)
sffc
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way they can be directly consumed by cpp2 instead of doing a cpp2-c2 folder. This is part of the plan for #427