Load functions array into config #441
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtrepta
force-pushed
the
load-functions-into-config
branch
from
d9d498d to
028ecce
Compare
gtrepta
commented
Jan 31, 2025
| @@ -91,6 +91,12 @@ module KMIR-CONFIGURATION | |||
| // FIXME where do we put the "GlobalAllocs"? in the heap, presumably? | |||
| // function store, Int -> Body | |||
| <functions> .Map </functions> | |||
| <function-names> | |||
| <function-name multiplicity="*" type="Map"> | |||
| <ty> 0 </ty> | |||
There was a problem hiding this comment.
This might need to be MIRInt and not just Int. I didn't run into an issue here when I was testing this though.
* Change `CALLER` to have sort `Ty` * build composed function map * adjust getBlocks helper to operate on MonoItemKind
* make target optional in stack frame * use `Ty` sort for function lookup table (instead of `MIRInt`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Lookup in the functions array when handling a call terminator
Stretch goal: Fuse the
<functions>and<function-names>cells together.