Updated project to use cargo without building rustc
#439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still requires merge of `smir-pretty` to use `rustup`
9 tasks
dkcumming
added a commit
to runtimeverification/stable-mir-json
that referenced
this pull request
Jan 30, 2025
Changing to use `rustup` for the Rust compiler now that we are not on our own fork. - [x] Need `build.rs` so that correct rust version is used with components installed - [x] Need to update README.md - [x] Building with `Makefile` needs to be removed - [x] Handling tests with `Makefile` needs to change to use `cargo` - [x] CI needs to be updated succesfully - [x] Need to handle golden tests difference - [x] Need to make sure this will still work with `mir-semantics` ([see this PR](runtimeverification/mir-semantics#439)) Moved to future work: - [ ] Change tests to use `cargo test` ? Could remove `Makefile` entirely then - [ ] Need to make sure this will still work with extracting stable-mir-json for cargo projects / `std lib`
dkcumming
changed the title
Makefile to use cargocargo without building rustc
dkcumming
force-pushed
the
dc/use-rustup-and-cargo
branch
from
eef947e to
03766ee
Compare
dkcumming
force-pushed
the
dc/use-rustup-and-cargo
branch
from
342d161 to
5da300f
Compare
dkcumming
force-pushed
the
dc/use-rustup-and-cargo
branch
from
5da300f to
0b3583d
Compare
…ion/mir-semantics into dc/use-rustup-and-cargo
jberthold
approved these changes
Jan 31, 2025
|
Thank you for the help with the CI stuff @jberthold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making mir-semantics compatible with PR where smir-pretty uses rustup