Optimize pyk.kast.inner.collect
#4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
commented
Dec 10, 2024
ehildenb
reviewed
Dec 10, 2024
ehildenb
reviewed
Dec 10, 2024
ehildenb
approved these changes
Dec 10, 2024
The previous implementation called `bottom_up` and as a side effect created a deep copy of the input term.
tothtamas28
force-pushed
the
kast-collect
branch
from
53a8cc2 to
692603c
Compare
automergerpr-permission-manager
bot
merged commit c4d9777
into
develop
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation called
bottom_upand as a side effect created a deep copy of the input term.